[libcxx-commits] [PATCH] D98720: [libc++] Consistent style on _LIBCPP_CLANG_VER tests in <type_traits>

Tue Mar 16 09:34:15 PDT 2021

zoecarver added a comment.

Thanks, Arthur. The tests (and regression tests) should ensure that these issues don't exist on GCC. Not sure how to test this on MSVC (but I think that's "OK" because we don't really test anything on MSVC).

================
Comment at: libcxx/include/type_traits:1132

-// In clang 9 and lower, this builtin did not work for nullptr_t. Additionally, in C++03 mode,
-// nullptr isn't defined by the compiler so, this builtin won't work.
-#if __has_keyword(__is_fundamental) && _LIBCPP_CLANG_VER > 900 && !defined(_LIBCPP_CXX03_LANG)
+// Before Clang 10, __is_fundamental didn't work for nullptr_t.
+// In C++03 nullptr_t is library-provided but must still count as "fundamental."
----------------
Nit: I think this means we won't take this path on Clang 9.0.1 anymore (which is maybe OK). 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98720/new/

https://reviews.llvm.org/D98720