[libcxx-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data
Jeremy Morse via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 16 07:11:12 PDT 2021
jmorse added a comment.
It turns out there's a plain old windows-has-different-slashes problem going on. In the Test object __init__ method, the call to `os.sep.join` in this patch produces the string "subdir\ccc.txt", which won't match "subdir/ccc.txt" that you load from the the .lit_test_times.txt file. That then leads to no time being loaded for ccc.txt, and it gets mis-ordered.
I think the stale .lit_test_times.txt thing was a slight red-herring, but it's because my usual workflow is:
- run `ninja check-llvm` or similar to run all tests,
- run llvm-lit directly on any tests that fail
And without running ninja, the "preparing lit tests" step isn't performed, meaning .lit_test_times.txt isn't cleaned up. This means none of the buildbots are going to fail from a stale file as they always run all the tests, but it'll be a bit awkward for anyone running lit manually IMO. Making it idempotent would be highly appreciated!
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits