[libcxx-commits] [PATCH] D98696: [libcxx] [test] Explicitly check that some env vars are ignored in the temp_dir_path test

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Awesome, LGTM mod comments!



================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp:74
+#else
+        {"USERPROFILE", env.create_dir("dir5")}
 #endif
----------------
Trailing commas on lines 72 and 74, please.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp:145
+        // Check that we return the same as above when no vars were defined.
+        TEST_CHECK(ret == fallback);
     }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98696/new/

https://reviews.llvm.org/D98696