[libcxx-commits] [PATCH] D98641: [libcxx] [test] Fix the last_write_time test to work on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 16 03:50:26 PDT 2021


mstorsjo added a comment.

In this one, a lot of the issues revolve around the test itself using the ´stat()` function (which exists but is crippled and doesn't do the right thing regarding symlinks) - would it be better to simply reimplement a "proper" checker of last write time here, i.e. include a stripped down version of the stat/last_write_time from the libc++ implementation itself?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98641/new/

https://reviews.llvm.org/D98641



More information about the libcxx-commits mailing list