[libcxx-commits] [PATCH] D97283: [libcxx][type_traits] is_unsigned is false for enum types

[Tomas Matheson via Phabricator via libcxx-commits]

tmatheson marked 4 inline comments as done.
tmatheson added inline comments.


================
Comment at: libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_signed.pass.cpp:58
+
+class NotEmpty {
+  virtual ~NotEmpty();
----------------
Quuxplusone wrote:
> zoecarver wrote:
> > I know this wasn't you, but I really don't like the name `NotEmpty`. Maybe call this `VirtualDestructor` or something. 
> This type is cut-and-pasted all over the place, so please change it everywhere (which means change it in a separate PR) or not at all.
I'll leave it as NotEmpty since it is called that elsewhere


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97283/new/

https://reviews.llvm.org/D97283