[libcxx-commits] [PATCH] D98640: [libcxx] [test] Fix windows errors in fs.op.rename

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98640

Files:
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.rename/rename.pass.cpp


Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.rename/rename.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.rename/rename.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.rename/rename.pass.cpp
@@ -62,7 +62,10 @@
     } cases[] = {
         {dne, dne},
         {file, dir},
+#ifndef _WIN32
+        // Overwriting a file with a directory isn't an error with MoveFileExW.
         {dir, file}
+#endif
     };
     for (auto& TC : cases) {
         auto from_before = status(TC.from);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98640.330724.patch
Type: text/x-patch
Size: 619 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210315/d0e652af/attachment.bin>