[libcxx-commits] [PATCH] D98139: [libcxx] [test] Fix temp_directory_path for windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp:67
         {"TEMPDIR", env.create_dir("dir4")}
+#endif
     };
----------------
Quuxplusone wrote:
> Is there any significance to starting with `dir2` on Windows versus `dir1` on POSIX?
> 
> Also, this is scope creep, but do you maybe want to (in a separate PR) make a test case to show that the setting of env var `TMPDIR` is correctly //ignored// on Windows?
Not really, just copy/paste laziness, I can change it to start with `dir1` there too.

Hmm, I guess I could try to extend the test to check for ignored variables too, as a later patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98139/new/

https://reviews.llvm.org/D98139