[libcxx-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

[James Henderson via Phabricator via libcxx-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

In D98179#2626179 <https://reviews.llvm.org/D98179#2626179>, @davezarzycki wrote:

> Might somebody be willing to sign off on this change (this week or next)? I'd like to cherry-pick it to Swift's LLVM branch. Thanks for all the feedback so far.

LGTM, but probably best to get someone else to confirm they're happy too.



================
Comment at: llvm/utils/lit/lit/cl_arguments.py:159-161
+    #selection_group.add_argument("--only-failures",
+    #        help="Only run tests that failed the previous testing cycle",
+    #        action="store_true")
----------------
Please delete this before pushing.


================
Comment at: llvm/utils/lit/lit/main.py:74-75
 
+    #if opts.only_failures:
+    #    selected_tests = [t for t in selected_tests if t.previous_failure]
+
----------------
Please delete this before pushing.


================
Comment at: llvm/utils/lit/tests/shtest-shell.py:11
 # on stdout-encoding.txt
+# FIXME: lit's testing sets source_root == exec_root which complicates running lit more than once per test
+# RUN: rm -f %{inputs}/shtest-shell/.lit_test_times.txt
----------------
Nit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98179/new/

https://reviews.llvm.org/D98179