[libcxx-commits] [PATCH] D98573: [libc++] Remove most of the special logic for "noexcept iterators" in basic_string
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Mar 14 20:09:22 PDT 2021
Quuxplusone updated this revision to Diff 330552.
Quuxplusone added a comment.
> Not if you have already reallocated the string and invalidated existing pointers and iterators.
Yikes!! Yes, you're right. I've added a new regression test for `append` (which fails before this patch, and also failed with the previous iteration of this patch). Am I adding too many epicycles to `append`? Should we just do the libstdc++ thing and make these functions always allocate a temporary string? Perhaps "anybody who cares that much about performance should just use the pointer+length overloads of these methods, not the arbitrary-input-iterator overloads"?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 26205 bytes
Desc: not available
More information about the libcxx-commits