[libcxx-commits] [PATCH] D98154: [libcxx] adds concept std::regular

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

@Quuxplusone please check 8d4af1b <https://reviews.llvm.org/rG8d4af1b6e033fc6eba52d862cd93dc8939fea916>.



================
Comment at: libcxx/test/std/concepts/object/regular.compile.pass.cpp:147
+static_assert(
+    !std::regular<std::tuple<std::runtime_error, std::overflow_error> >);
+static_assert(!std::regular<std::nullopt_t>);
----------------
Quuxplusone wrote:
> `/> >/>>/` since this test doesn't need C++03 portability
clang-format issue, not arguing over this.


================
Comment at: libcxx/test/std/concepts/object/regular.compile.pass.cpp:159
+
+// On equality comparability
+static_assert(!std::regular<const_copy_assignment const>);
----------------
Quuxplusone wrote:
> Should this say `/On/No/`?
Both are semantically correct! I meant this as "on some topic of concern", but I think "no equality comparability" reads better here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98154/new/

https://reviews.llvm.org/D98154