[libcxx-commits] [PATCH] D97166: [libcxx] [docs] Update docs about how to build for Windows

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:104
+If Git for Windows is available, that can be used to provide the bash
+shell, by adding the right bin directory to the path, e.g.
+`set PATH=%PATH%;C:\Program Files\Git\usr\bin`.
----------------
`/shell, by/shell by/`


================
Comment at: libcxx/docs/BuildingLibcxx.rst:115
+
+In either case, in the right environment, run:
 
----------------
`/case, in the right environment, run:/case, then run:/`
I assume "in the right environment" means simply "following right after the environment-setup step that we just explained in the previous paragraph." There's no need to scare the reader with the implication that their environment could at this point //still// be wrong in some unspecified way.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:125
           -DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=NO                                     ^
           \path\to\libcxx
+  > ninja cxx
----------------
Why forward-slashes on line 123 and backslashes on line 125? I think they should be forward-slashes in both places, if that's possible (i.e. if it'd do the right thing). And if the backslashes are important for correctness, that should probably be explained here.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:129-133
+Note that if running in an MSYS2 shell and the MSYS2 provided clang package
+is installed, that one ends up picked up as tests invoke plain `clang++`
+instead of `clang-cl`. As the MSYS2 provided `clang++` binary defaults to
+a non-MSVC target, add `-DLIBCXX_TARGET_TRIPLE=x86_64-windows-msvc` to the
+cmake configuration in this case.
----------------



================
Comment at: libcxx/docs/BuildingLibcxx.rst:148
+  > cmake -G Ninja                                                                    \
+
+          -DCMAKE_C_COMPILER=clang                                                    \
----------------
remove blank line


================
Comment at: libcxx/www/index.html:133-135
+    The library also does work for Windows (both MSVC style environments,
+    built with clang-cl, and MinGW environments), although support for that
+    platform is less mature than for the platforms above.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97166/new/

https://reviews.llvm.org/D97166