[libcxx-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

David Zarzycki via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 12 03:16:09 PST 2021


davezarzycki updated this revision to Diff 330194.
davezarzycki added a comment.

I've made all of the requested changes to date. Two notes:

1. One cannot simply omit the first argument to `split()` if the second is provided. As I just learned, python will complain. I switched the first parameter to `None` as a compromise.
2. For the record, I disagree with the use of the word "run" over "start" but this isn't something that I care enough about to resist changing the patch. Strictly speaking, `lit` only controls when tests start, not anything about how they run. With enough cores, tests will complete in a fairly predictable order despite any effort to start tests in a different order (or randomly).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98179/new/

https://reviews.llvm.org/D98179

Files:
  llvm/docs/CommandGuide/lit.rst
  llvm/test/Unit/lit.cfg.py
  llvm/utils/lit/lit/Test.py
  llvm/utils/lit/lit/TestingConfig.py
  llvm/utils/lit/lit/cl_arguments.py
  llvm/utils/lit/lit/discovery.py
  llvm/utils/lit/lit/main.py
  llvm/utils/lit/tests/Inputs/early-tests/aaa.txt
  llvm/utils/lit/tests/Inputs/early-tests/bbb.txt
  llvm/utils/lit/tests/Inputs/early-tests/lit.cfg
  llvm/utils/lit/tests/Inputs/early-tests/subdir/ccc.txt
  llvm/utils/lit/tests/Inputs/reorder/.lit_test_times.txt
  llvm/utils/lit/tests/Inputs/reorder/aaa.txt
  llvm/utils/lit/tests/Inputs/reorder/bbb.txt
  llvm/utils/lit/tests/Inputs/reorder/lit.cfg
  llvm/utils/lit/tests/Inputs/reorder/subdir/ccc.txt
  llvm/utils/lit/tests/early-tests.py
  llvm/utils/lit/tests/ignore-fail.py
  llvm/utils/lit/tests/reorder.py
  llvm/utils/lit/tests/shtest-shell.py
  mlir/test/Unit/lit.cfg.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98179.330194.patch
Type: text/x-patch
Size: 15302 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210312/144467ef/attachment-0001.bin>


More information about the libcxx-commits mailing list