[libcxx-commits] [PATCH] D98154: [libcxx] adds concept std::regular

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/concepts/object/regular.compile.pass.cpp:144
+
+// Not default_initialzable
+static_assert(!std::regular<std::runtime_error>);
----------------
`/lz/liz/`


================
Comment at: libcxx/test/std/concepts/object/regular.compile.pass.cpp:147
+static_assert(
+    !std::regular<std::tuple<std::runtime_error, std::overflow_error> >);
+static_assert(!std::regular<std::nullopt_t>);
----------------
`/> >/>>/` since this test doesn't need C++03 portability


================
Comment at: libcxx/test/std/concepts/object/regular.compile.pass.cpp:159
+
+// On equality comparability
+static_assert(!std::regular<const_copy_assignment const>);
----------------
Should this say `/On/No/`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98154/new/

https://reviews.llvm.org/D98154