[libcxx-commits] [PATCH] D98443: [libcxx] [test] Use GetWindowsInaccessibleDir() in a couple more tests

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 11 12:02:14 PST 2021


mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp:106
+#ifdef _WIN32
+        TEST_CHECK(ErrorIs(ec, std::errc::not_a_directory));
+#else
----------------
curdeius wrote:
> Just thinking out loud, if you used `nested_dir = dir` on Windows, wouldn't that provoke `permission_denied` error?
That's true, why didn't I just go with that? Updating...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98443/new/

https://reviews.llvm.org/D98443



More information about the libcxx-commits mailing list