[libcxx-commits] [PATCH] D98406: [libcxx] [test] Use a string_view of the native path type in the concat test
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 11 07:34:30 PST 2021
Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.
LGTM, although this pre-existing "manually type-cast to a pointer type to trigger the appropriate `operator X*()`" technique is hecka confusing. I would be tempted to give `class MultiStringView` some additional member function templates for sanity's sake: `TC.rhs.as_string_view<path::value_type>()` and perhaps `TC.rhs.as_cstr<path::value_type>()`.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits