[libcxx-commits] [PATCH] D97443: [libcxx] adds concept std::copyable

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/concepts/object/copyable.compile.pass.cpp:98
+static_assert(!std::copyable<volatile_copy_assignment volatile>);
+static_assert(std::copyable<cv_copy_assignment const volatile>);
+
----------------
I think you should change `volatile_copy_assignment` as indicated above, so that you can remove the `!` character on line 97. Then lines 96,97,98 will be parallel to each other, which will be good.
Lines 96,97,98 have nothing to do with the comment `// Not assignable` on line 93. I recommend moving lines 96,97,98 up to line 74-ish.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97443/new/

https://reviews.llvm.org/D97443