[libcxx-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

David Zarzycki via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 9 03:29:06 PST 2021


davezarzycki updated this revision to Diff 329277.
davezarzycki added a comment.
Herald added subscribers: libcxx-commits, lldb-commits, arichardson.
Herald added projects: LLDB, libc++.
Herald added a reviewer: libc++.

I believe I've addressed all of the feedback to date.

I've also fixed the regression. I had hoped to avoid adding `test_times` as a parameter to a bunch of methods, but adding that dictionary to the test suite makes `lit` effectively single threaded as the worker threads fought over what I assume is the global python interpreter lock.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98179/new/

https://reviews.llvm.org/D98179

Files:
  libcxx/utils/libcxx/test/format.py
  libcxx/utils/libcxx/test/googlebenchmark.py
  lldb/test/API/lldbtest.py
  llvm/docs/CommandGuide/lit.rst
  llvm/test/Unit/lit.cfg.py
  llvm/utils/lit/lit/Test.py
  llvm/utils/lit/lit/TestingConfig.py
  llvm/utils/lit/lit/cl_arguments.py
  llvm/utils/lit/lit/discovery.py
  llvm/utils/lit/lit/formats/base.py
  llvm/utils/lit/lit/formats/googletest.py
  llvm/utils/lit/lit/main.py
  llvm/utils/lit/tests/Inputs/early-tests/aaa.txt
  llvm/utils/lit/tests/Inputs/early-tests/bbb.txt
  llvm/utils/lit/tests/Inputs/early-tests/lit.cfg
  llvm/utils/lit/tests/Inputs/early-tests/subdir/ccc.txt
  llvm/utils/lit/tests/Inputs/reorder/.lit_test_times.txt
  llvm/utils/lit/tests/Inputs/reorder/aaa.txt
  llvm/utils/lit/tests/Inputs/reorder/bbb.txt
  llvm/utils/lit/tests/Inputs/reorder/lit.cfg
  llvm/utils/lit/tests/Inputs/reorder/subdir/ccc.txt
  llvm/utils/lit/tests/early-tests.py
  llvm/utils/lit/tests/ignore-fail.py
  llvm/utils/lit/tests/reorder.py
  llvm/utils/lit/tests/shtest-shell.py
  mlir/test/Unit/lit.cfg.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98179.329277.patch
Type: text/x-patch
Size: 20264 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210309/118e9ec0/attachment-0001.bin>


More information about the libcxx-commits mailing list