[libcxx-commits] [PATCH] D98109: [libcxx] Make path::absolute return paths with separators in preferred form

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 8 13:46:36 PST 2021

mstorsjo added a comment.

In D98109#2612320 <https://reviews.llvm.org/D98109#2612320>, @curdeius wrote:

> Oh, silly me. You're totally right.
> It doesn't change though that make_preferred isn't used. FWIW, https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/src/filesystem/ops.cc#L66.

Yeah, that's true. But as a I said, it's not much of a reference for intended behaviour on Windows, as it's kinda spotty.

So I guess the spec doesn't forbid it, but doesn't either say it should be done - so the only reason to do it would be to superficially match the MS STL behaviour. And I'd agree with your point that we shouldn't be changing actual behaviour just to superficially match things like that. So with that, D98215 <https://reviews.llvm.org/D98215> sounds like a more sensible choice - if we get another reviewer to +1 that one too :-)

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list