[libcxx-commits] [PATCH] D98139: [libcxx] [test] Fix temp_directory_path for windows

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 8 13:04:16 PST 2021


curdeius added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp:122
+#ifndef _WIN32
+        // On Windows, the function falls back to C:\Windows instead.
         TEST_CHECK(ret == "/tmp");
----------------
Nit: the Windows folder is not necessarily C:\Windows. Don't bother to change it before landing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98139/new/

https://reviews.llvm.org/D98139



More information about the libcxx-commits mailing list