[libcxx-commits] [PATCH] D98139: [libcxx] [test] Fix temp_directory_path for windows

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius accepted this revision as: curdeius.
curdeius added a comment.

LGTM if you clarify the comment.



================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp:126
+#ifndef _WIN32
+        // On windows, a different fallback is used.
         TEST_CHECK(ret == "/tmp");
----------------
Nit: capital in Windows.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp:126
+#ifndef _WIN32
+        // On windows, a different fallback is used.
         TEST_CHECK(ret == "/tmp");
----------------
curdeius wrote:
> Nit: capital in Windows.
I'd rather go for a precise piece of information in the comment, as you wrote in the revision summary, the fallback is the Windows folder (https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-gettemppatha#remarks).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98139/new/

https://reviews.llvm.org/D98139