[libcxx-commits] [PATCH] D98129: [CMake][runtimes] Add file level dependency to merge_archives commands

Mon Mar 8 11:04:12 PST 2021

mstorsjo added a comment.

In D98129#2611778 <https://reviews.llvm.org/D98129#2611778>, @compnerd wrote:

> Im afraid I dont understand the purpose of this change.  libunwind isn't meant to be merged into libc++/libc++abi.  The reasoning for libc++ to support merging libc++abi doesn't really apply to libunwind IMO.  Can you please elaborate what exactly the reasoning for this is?

Since 058c04c3ddecb4ecc81655c91b7aa0e7a5ef0ab1 libcxxabi has explicit options for merging in libunwind. And while not strictly needed in the same sense as libcxxabi + libcxx, I can see that it could be convenient.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98129/new/

https://reviews.llvm.org/D98129