[libcxx-commits] [PATCH] D97473: [SystemZ][z/OS] vasprintf fix libc++

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/src/support/win32/locale_win32.cpp:122
+    va_end(ap_copy);
+    return str_size;
 }
----------------
I don't think you need this diff. We receive a `va_list`; we pass it (once) to `__libcpp_vasprintf`. One source, one sink. No copy should be needed.

However, you do need to modify `__libcpp_vasprintf` in `src/support/win32/support.cpp` per Louis' comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97473/new/

https://reviews.llvm.org/D97473