[libcxx-commits] [libcxx] b9f169f - [libcxx] Document windows specifics regarding file_type and perms. NFC.

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2021-03-08T15:27:07+02:00
New Revision: b9f169fb7dcd09721a4487801873a61a1e20da7e

URL: https://github.com/llvm/llvm-project/commit/b9f169fb7dcd09721a4487801873a61a1e20da7e
DIFF: https://github.com/llvm/llvm-project/commit/b9f169fb7dcd09721a4487801873a61a1e20da7e.diff

LOG: [libcxx] Document windows specifics regarding file_type and perms. NFC.

This was requested in the review of D98138.

Differential Revision: https://reviews.llvm.org/D98155

Added: 
    

Modified: 
    libcxx/include/filesystem

Removed: 
    


################################################################################
diff  --git a/libcxx/include/filesystem b/libcxx/include/filesystem
index 58a1ef239b21..372b28f285b0 100644
--- a/libcxx/include/filesystem
+++ b/libcxx/include/filesystem
@@ -276,6 +276,8 @@ struct _LIBCPP_TYPE_VIS space_info {
   uintmax_t available;
 };
 
+// On Windows, the library never identifies files as  block, character, fifo
+// or socket.
 enum class _LIBCPP_ENUM_VIS file_type : signed char {
   none = 0,
   not_found = -1,
@@ -289,6 +291,10 @@ enum class _LIBCPP_ENUM_VIS file_type : signed char {
   unknown = 8
 };
 
+// On Windows, these permission bits map to one single readonly flag per
+// file, and the executable bit is always returned as set. When setting
+// permissions, as long as the write bit is set for either owner, group or
+// others, the readonly flag is cleared.
 enum class _LIBCPP_ENUM_VIS perms : unsigned {
   none = 0,