[libcxx-commits] [PATCH] D98166: [libcxx] Test accessing a directory on windows that gives "access denied" errors

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo updated this revision to Diff 328980.
mstorsjo added a comment.

Moved the setup code to a helper function, strictly requiring that
the path exists for the tests to pass.

Not using TEST_*() macros in the helper header, as the individual test
cases are written in a variety of ways, and those macros only work in
certain setups. (Alternatively one could forcibly do assert() in the
helper header.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98166/new/

https://reviews.llvm.org/D98166

Files:
  libcxx/src/filesystem/directory_iterator.cpp
  libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.cons/path.pass.cpp
  libcxx/test/std/input.output/filesystems/class.directory_iterator/directory_iterator.members/ctor.pass.cpp
  libcxx/test/std/input.output/filesystems/class.rec.dir.itr/rec.dir.itr.members/ctor.pass.cpp
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp
  libcxx/test/support/filesystem_test_helper.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98166.328980.patch
Type: text/x-patch
Size: 5977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210308/f9c0c70b/attachment.bin>