[libcxx-commits] [PATCH] D97283: [libcxx][type_traits] is_unsigned is false for enum types

[Tomas Matheson via Phabricator via libcxx-commits]

tmatheson updated this revision to Diff 328968.
tmatheson added a comment.

- Add #ifdef around the __is_unsigned condition based on clang version number. I'm not convinced the value of this outweighs the noise it creates. But with it, this patch can be landed before or after D98104 <https://reviews.llvm.org/D98104>.

- Add EnumSigned and EnumUnsigned to is_arithmetic tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97283/new/

https://reviews.llvm.org/D97283

Files:
  libcxx/include/type_traits
  libcxx/test/std/utilities/meta/meta.unary/meta.unary.comp/is_arithmetic.pass.cpp
  libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_signed.pass.cpp
  libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_unsigned.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97283.328968.patch
Type: text/x-patch
Size: 7624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210308/1f31029e/attachment.bin>