[libcxx-commits] [PATCH] D96986: [libc++] Drop template layer when using vsnprintf

Mon Mar 8 00:27:40 PST 2021

curdeius added inline comments.

================
Comment at: libcxx/include/__config:1452

+#ifdef __GNUC__
+#  define _LIBCPP_PRINTFILE(fmtarg, firstvararg) \
----------------
joerg wrote:
> curdeius wrote:
> > Does clang-cl support this attribute? If yes, then it should be `#if defined(__GNUC_) || defined(__clang__)`.
> It seems to work as is with clang-cl.
I just tested it and `__GNUC__` is *not* defined by clang-cl.
Please adjust.
Or @Quuxplusone, please update this in D98097, depending on how you both want to proceed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96986/new/

https://reviews.llvm.org/D96986