[libcxx-commits] [PATCH] D98138: [libcxx] [test] Don't test CharFile (/dev/null) on windows

Sun Mar 7 10:32:10 PST 2021

mstorsjo added a comment.

In D98138#2609952 <https://reviews.llvm.org/D98138#2609952>, @curdeius wrote:

> Have you heard of `nul` special file on Windows?
> https://gcc.gnu.org/legacy-ml/gcc-patches/2005-05/msg01793.html
> I haven't tested it yet but maybe using it on Win instead of /dev/null might be a good idea?

Good point, but neither our implementation nor the MS STL one actually identify files as `file_type::character`, see https://github.com/microsoft/STL/blob/main/stl/inc/filesystem#L1882 which says:

>   character, // not used in this implementation; theoretically some special files like CON might qualify, but querying for this is extremely expensive and unlikely to be useful in practice

================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp:116
         {static_env.SymlinkToDir, file_type::directory},
         // Block files tested elsewhere
+#ifndef _WIN32
----------------
Quuxplusone wrote:
> You might adjust this comment to `// file_type::block is tested elsewhere`, just so that people don't assume it's related to the `#ifndef` on the next line.
> (And ditto in the other test file, as well.)
Sure, I can do that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98138/new/

https://reviews.llvm.org/D98138