[libcxx-commits] [PATCH] D98140: [libcxx] [test] Fix building create_directory in MSVC configurations

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Accepted iff you add the requested comment.



================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp:35
 fs::perms read_umask() {
-    mode_t old_mask = umask(0);
+    auto old_mask = umask(0);
     umask(old_mask); // reset the mask to the old value.
----------------
Please add a comment on this line: `// int on Windows, mode_t on POSIX`.
Otherwise someone'll just change it back in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98140/new/

https://reviews.llvm.org/D98140