[libcxx-commits] [PATCH] D98138: [libcxx] [test] Don't test CharFile (/dev/null) on windows

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Mar 7 09:06:37 PST 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp:116
         {static_env.SymlinkToDir, file_type::directory},
         // Block files tested elsewhere
+#ifndef _WIN32
----------------
You might adjust this comment to `// file_type::block is tested elsewhere`, just so that people don't assume it's related to the `#ifndef` on the next line.
(And ditto in the other test file, as well.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98138/new/

https://reviews.llvm.org/D98138



More information about the libcxx-commits mailing list