[libcxx-commits] [PATCH] D98127: [libcxx] [test] Clarify and improve consistency in lexically_relative_and_proximate.pass.cpp. NFC.
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Mar 7 01:52:28 PST 2021
mstorsjo updated this revision to Diff 328851.
mstorsjo added a comment.
Renamed the variable, using .empty() instead of .native().empty()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98127/new/
https://reviews.llvm.org/D98127
Files:
libcxx/test/std/input.output/filesystems/class.path/path.member/path.gen/lexically_relative_and_proximate.pass.cpp
Index: libcxx/test/std/input.output/filesystems/class.path/path.member/path.gen/lexically_relative_and_proximate.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.member/path.gen/lexically_relative_and_proximate.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.member/path.gen/lexically_relative_and_proximate.pass.cpp
@@ -84,10 +84,9 @@
// [path.gen] lexically_proximate
// Returns: If the value of lexically_relative(base) is not an empty path,
// return it. Otherwise return *this.
- const fs::path proximate_expected = output.native().empty() ? p
- : output;
- if (!PathEq(proximate_expected, proximate_output))
- ReportErr("path::lexically_proximate", proximate_output, proximate_expected);
+ const fs::path proximate_expect = expect.empty() ? p : expect;
+ if (!PathEq(proximate_output, proximate_expect))
+ ReportErr("path::lexically_proximate", proximate_output, proximate_expect);
}
return Failed;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98127.328851.patch
Type: text/x-patch
Size: 1069 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210307/8a00fa16/attachment.bin>
More information about the libcxx-commits
mailing list