[libcxx-commits] [PATCH] D97913: [runtimes] Use add_lit_testsuite to register lit testsuites

Sat Mar 6 02:53:03 PST 2021

davezarzycki added a comment.

Hello. I have an auto-bisecting cron job that has identified this change as the source of a regression. Specifically, after this change, the following libcxx tests start failing. Given that this patch is partially reverted already, I'm going to revert the libcxx part too. If people need help debugging this, I'm happy to help.

Failed Tests (31):

  libc++ :: libcxx/experimental/memory/memory.resource.global/global_memory_resource_lifetime.pass.cpp
  libc++ :: libcxx/experimental/memory/memory.resource.global/new_delete_resource_lifetime.pass.cpp
  libc++ :: libcxx/gdb/gdb_pretty_printer_test.sh.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.ctor/default.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.eq/equal.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.eq/not_equal.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/allocate.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_pair.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_pair_const_lvalue_pair.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_pair_rvalue.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_pair_values.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair_evil.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_types.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/deallocate.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/destroy.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/resource.pass.cpp
  libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/select_on_container_copy_construction.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_deque_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_forward_list_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_list_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_map_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_regex_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_set_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_string_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_unordered_map_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_unordered_set_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.aliases/header_vector_synop.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.global/default_resource.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.global/new_delete_resource.pass.cpp
  libc++ :: std/experimental/memory/memory.resource.global/null_memory_resource.pass.cpp

And here is one failure, if it helps:

FAIL: libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp (72395 of 81491)

- TEST 'libc++ :: std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp' FAILED ********************

Script:
-------

: 'COMPILED WITH';  /usr/bin/clang++ /home/dave/ro_s/lp/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp -v --target=x86_64-unknown-linux-gnu -include /tmp/_update_lc/r/projects/libcxx/__config_site -include /home/dave/ro_s/lp/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/dave/ro_s/lp/libcxx/include -I/tmp/_update_lc/r/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/dave/ro_s/lp/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/tmp/_update_lc/r/projects/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/Output/construct_piecewise_pair.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1  -L/tmp/_update_lc/r/./lib -Wl,-rpath,/tmp/_update_lc/r/./lib -nodefaultlibs /tmp/_update_lc/r/./lib/libc++.a -lc++abi -lm -lgcc_s -lgcc -lpthread -lrt -lc -lgcc_s -lgcc -latomic -lc++experimental -o /tmp/_update_lc/r/projects/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/Output/construct_piecewise_pair.pass.cpp.dir/t.tmp.exe

: 'EXECUTED AS';  "/usr/bin/python3.9" /home/dave/ro_s/lp/libcxx/test/../utils/run.py --execdir /tmp/_update_lc/r/projects/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/Output/construct_piecewise_pair.pass.cpp.dir --codesign_identity "" --env  --  /tmp/_update_lc/r/projects/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/Output/construct_piecewise_pair.pass.cpp.dir/t.tmp.exe
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Exit Code: 1

Command Output (stderr):
------------------------

clang version 11.0.0 (Fedora 11.0.0-2.fc33)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-redhat-linux/10
Found candidate GCC installation: /usr/lib/gcc/x86_64-redhat-linux/10
Selected GCC installation: /usr/lib/gcc/x86_64-redhat-linux/10
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Selected multilib: .;@m64
 "/usr/bin/clang-11" -cc1 -triple x86_64-unknown-linux-gnu -emit-obj -mrelax-all -disable-free -disable-llvm-verifier -discard-value-names -main-file-name construct_piecewise_pair.pass.cpp -mrelocation-model static -mframe-pointer=all -fmath-errno -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -fno-split-dwarf-inlining -debugger-tuning=gdb -v -nostdinc++ -resource-dir /usr/lib64/clang/11.0.0 -include /tmp/_update_lc/r/projects/libcxx/__config_site -include /home/dave/ro_s/lp/libcxx/test/support/nasty_macros.h -I /home/dave/ro_s/lp/libcxx/include -I /tmp/_update_lc/r/projects/libcxx/include/c++build -D __STDC_FORMAT_MACROS -D __STDC_LIMIT_MACROS -D __STDC_CONSTANT_MACROS -I /home/dave/ro_s/lp/libcxx/test/support -D _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D _LIBCPP_DISABLE_AVAILABILITY -D _LIBCPP_HAS_THREAD_API_PTHREAD -D _LIBCPP_ABI_VERSION=1 -internal-isystem /usr/local/include -internal-isystem /usr/lib64/clang/11.0.0/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -Werror=thread-safety -Wuser-defined-warnings -Wno-macro-redefined -Wno-macro-redefined -std=c++2a -fdeprecated-macro -fdebug-compilation-dir /tmp/_update_lc/r/projects/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem -ferror-limit 19 -fcoroutines-ts -fgnuc-version=4.2.1 -fno-implicit-modules -fcxx-exceptions -fexceptions -faddrsig -o /tmp/construct_piecewise_pair-00f260.o -x c++ /home/dave/ro_s/lp/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp
clang -cc1 version 11.0.0 based upon LLVM 11.0.0 default target x86_64-unknown-linux-gnu
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
 /home/dave/ro_s/lp/libcxx/include
 /tmp/_update_lc/r/projects/libcxx/include/c++build
 /home/dave/ro_s/lp/libcxx/test/support
 /usr/local/include
 /usr/lib64/clang/11.0.0/include
 /usr/include
End of search list.
 "/usr/bin/ld" --hash-style=gnu --build-id --eh-frame-hdr -m elf_x86_64 -dynamic-linker /lib64/ld-linux-x86-64.so.2 -o /tmp/_update_lc/r/projects/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/Output/construct_piecewise_pair.pass.cpp.dir/t.tmp.exe /usr/lib/gcc/x86_64-redhat-linux/10/../../../../lib64/crt1.o /usr/lib/gcc/x86_64-redhat-linux/10/../../../../lib64/crti.o /usr/lib/gcc/x86_64-redhat-linux/10/crtbegin.o -L/tmp/_update_lc/r/./lib -L/usr/lib/gcc/x86_64-redhat-linux/10 -L/usr/lib/gcc/x86_64-redhat-linux/10/../../../../lib64 -L/usr/bin/../lib64 -L/lib/../lib64 -L/usr/lib/../lib64 -L/usr/lib/gcc/x86_64-redhat-linux/10/../../.. -L/usr/bin/../lib -L/lib -L/usr/lib /tmp/construct_piecewise_pair-00f260.o -rpath /tmp/_update_lc/r/./lib /tmp/_update_lc/r/./lib/libc++.a -lc++abi -lm -lgcc_s -lgcc -lpthread -lrt -lc -lgcc_s -lgcc -latomic -lc++experimental /usr/lib/gcc/x86_64-redhat-linux/10/crtend.o /usr/lib/gcc/x86_64-redhat-linux/10/../../../../lib64/crtn.o
/usr/bin/ld: /tmp/_update_lc/r/./lib/libc++experimental.a(memory_resource.cpp.o): in function `std::experimental::fundamentals_v1::pmr::__null_memory_resource_imp::do_allocate(unsigned long, unsigned long)':
memory_resource.cpp:(.text._ZNSt12experimental15fundamentals_v13pmr26__null_memory_resource_imp11do_allocateEmm[_ZNSt12experimental15fundamentals_v13pmr26__null_memory_resource_imp11do_allocateEmm]+0x2): undefined reference to `std::__throw_bad_alloc()'
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97913/new/

https://reviews.llvm.org/D97913