[libcxx-commits] [PATCH] D97443: [libcxx] adds concept std::copyable

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/test/std/concepts/object/copyable.compile.pass.cpp:111
+
+int main(int, char**) { return 0; }
----------------
I think this test can/should be a `.verify.cpp` test because there's not actually any runtime logic. 


================
Comment at: libcxx/test/std/concepts/object/copyable.h:1
+//===----------------------------------------------------------------------===//
+//
----------------
I think we generally want to put these in the `support` directory so they're not just floating around. But I don't feel strongly on this (if others disagree). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97443/new/

https://reviews.llvm.org/D97443