[libcxx-commits] [PATCH] D97904: [libcxx] updates the feature-test macro generator

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 19:13:43 PST 2021

cjdb added a comment.

In D97904#2606538 <https://reviews.llvm.org/D97904#2606538>, @ldionne wrote:

> In D97904#2605361 <https://reviews.llvm.org/D97904#2605361>, @cjdb wrote:
>> So are we addressing issues pre-merge or post-merge? A bit confused on this one, sorry.
> My ask was to change to
>   "depends": "defined(__cpp_concepts) && __cpp_concepts >= 201907L",
>   "internal_depends": "!defined(_LIBCPP_HAS_NO_CONCEPTS)",
> since that's what we really mean. The other feedback about the `depends` + `internal_depends` naming is something we can (and should) address separately. Ship it once you've applied the changes explained just above.
> Sorry about the lack of clarity in my review yesterday. I tried reviewing a lot of stuff before going OOO for an extended period of time and I think I went a little bit too fast. I should have explained better.

Gotcha, thanks for spelling it out :-)

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list