[libcxx-commits] [PATCH] D98097: [libc++] "Merged wording" for D98077 and D96986

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 18:45:09 PST 2021

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, mstorsjo, curdeius, joerg.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This is my attempt to merge D98077 <https://reviews.llvm.org/D98077> (bugfix the format strings for Windows paths, which use `wchar_t` not `char`) and D96986 <https://reviews.llvm.org/D96986> (replace C++ variadic templates with C-style varargs so that `__attribute__((format(printf)))` can be applied, for better safety). Those two patches merge-conflict with each other, and also I had some pretty heavy "requested changes" on D96986 <https://reviews.llvm.org/D96986>, so I decided to just show what I mean directly.

The one intentional functional change here is in `__create_what`. It now prints path1 and path2 in square-brackets //and// double-quotes, rather than just square-brackets. Prior to this patch, it would print either path double-quoted if-and-only-if it was the empty string. Now the double-quotes are always present. I doubt anybody's code is relying on the current format, right?

  rG LLVM Github Monorepo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98097.328718.patch
Type: text/x-patch
Size: 8441 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210306/c008ecd3/attachment.bin>

More information about the libcxx-commits mailing list