[libcxx-commits] [PATCH] D98077: [libcxx] Fix the format strings for formatting paths in directory_iterator.cpp

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/src/filesystem/filesystem_common.h:115
+#define PS_FMT "%s"
+#endif
+
----------------
How about moving the escaped-double-quotes into this format string?
```
#define PS_FMT "\"%ls\""
#define PS_FMT "\"%s\""
```
That'll make the call-sites look less wacky.

(I admit it doesn't really make any sense that we double-quote these paths in the first place. It's not as if we're going to actually escape the backslashes/quotes //in// the paths; so the quotation marks are kind of a lie. But I don't feel like unilaterally suggesting their complete removal.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98077/new/

https://reviews.llvm.org/D98077