[libcxx-commits] [PATCH] D98045: [libcxx] [test] Move the is_<platform> functions down to subclasses

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 13:44:12 PST 2021


mstorsjo added a comment.

In D98045#2606909 <https://reviews.llvm.org/D98045#2606909>, @ldionne wrote:

> LGTM, but FYI the whole `target_into.py` and even `config.py` will eventually be replaced by simpler setups like `libcxx/test/configs/libcxx-trunk-shared.cfg.in`. It's a slow process but I've been chipping at it little by little.

Ok, that sounds good to me, I'm not particularly attached to the current way of things, as long as the new setup is something that is flexible enough (and it looks like its) for oddball setups :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98045/new/

https://reviews.llvm.org/D98045



More information about the libcxx-commits mailing list