[libcxx-commits] [PATCH] D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 09:53:22 PST 2021


Quuxplusone added a comment.

I don't know if "defining that macro manually" is expected to be a supported configuration.
That said, source-diving suggests to me that //the macro is automatically defined whenever the sanitizers are turned on.//
Does anyone test libc++ with sanitizers? (Does buildkite?) Could someone perhaps confirm that this fixes some specific sanitizer-related test failure?

`DISABLE_NEW_COUNT` is already checked in two places in the test suite: 
std/containers/sequences/list/list.modifiers/insert_iter_value.pass.cpp
std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/auto_ptr.pass.cpp
but I have not looked into the details or history.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98006/new/

https://reviews.llvm.org/D98006



More information about the libcxx-commits mailing list