[libcxx-commits] [PATCH] D46443: Add missing cstdalign header

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:8
+//===----------------------------------------------------------------------===//
+
+// test <cstdalign>
----------------
I think we should add `// REQUIRES: c++03 || c++11 || c++14 || c++17`, because a conforming implementation could be not shipping the header in C++20 and beyond.


================
Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:14-28
+#ifdef alignas
+#error alignas should not be a macro in C++
+#endif
+
+#ifdef alignof
+#error alignof should not be a macro in C++
+#endif
----------------
This can be moved outside of `main()`.


================
Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:27
+#ifndef __alignof_is_defined
+#error __alignof_is_defined not defined
+#endif
----------------
I'm not seeing `__alignof_is_defined` anywhere in the spec?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46443/new/

https://reviews.llvm.org/D46443