[libcxx-commits] [PATCH] D98045: [libcxx] [test] Move the is_<platform> functions down to subclasses

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 08:14:04 PST 2021


curdeius accepted this revision as: curdeius.
curdeius added a comment.

LGTM. Hopefully that doesn't break any "exotic" setups.



================
Comment at: libcxx/utils/libcxx/test/target_info.py:24-25
 
     def platform(self):
         return sys.platform.lower().strip()
 
----------------
Just a remark. No action needed.
`platform()` (here and in `LinuxLocalTI`) seems unused now unless I'm mistaken.
But it seems it's the case of some other methods especially in `LinuxLocalTI`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98045/new/

https://reviews.llvm.org/D98045



More information about the libcxx-commits mailing list