[libcxx-commits] [PATCH] D98044: [SystemZ][z/OS] Missing locale functions libc++

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

Some nitty-picky comments.



================
Comment at: libcxx/src/support/ibm/xlocale_zos.cpp:18
+locale_t newlocale(int category_mask, const char* locale, locale_t base) {
+  // Maintain current locale name(s) to restore later
+  std::string current_loc_name(setlocale(LC_ALL, 0));
----------------
Nit (here and elsewhere): comments are supposed to be full phrases with full stops (dots) at the end.


================
Comment at: libcxx/src/support/ibm/xlocale_zos.cpp:77
+    // Set locales and check for errors
+    bool isError = 
+      (newloc->category_mask & LC_COLLATE_MASK && 
----------------
CamelCase? If think that snake_case should be used.


================
Comment at: libcxx/src/support/ibm/xlocale_zos.cpp:101
+
+  // current_loc_name might be a comma-seperated locale name list
+  if (current_loc_name.find(',') != std::string::npos) {
----------------
Typo: separated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98044/new/

https://reviews.llvm.org/D98044