[libcxx-commits] [PATCH] D98028: [libcxx] [test] Add an option to ssh.py for using a different temp path

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D98028#2606655 <https://reviews.llvm.org/D98028#2606655>, @mstorsjo wrote:

> Adding more arguments to this script really shouldn't be a burden for the rest of the projects; these arguments are only touched by the users who need them, setting them manually within `-DLIBCXX_EXECUTOR="path/to/ssh.py --host=myremote --tempdir=/some/temp/dir"` (where one need to have `--host` anyway).

With experience from cross testing in other projects, this kind of parameter is pretty much a requirement anyway. When building and executing tests locally, you never need to specify the path where to do things, as that's implicit from where you do the build (or an explicit argument to cmake). But in any case when executing things on a remote system, one would want to allow the user to specify where in the filesystem of the remote things would be placed, not assuming anything about either being able to use the same path on both systems, or hardcoded assumptions about where to place things on the remote.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98028/new/

https://reviews.llvm.org/D98028