[libcxx-commits] [PATCH] D98026: [libcxx] [test] Fix cross testing for windows

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 06:37:28 PST 2021


curdeius added a comment.

When cross-compiling (I imagine that you build on Linux and test on Windows), it seems logical to be using `WindowsRemoteTI`, no?
I understand that it's not there and would be almost identical to `WindowsLocalTI`, but it would make things clearer IMO.

Another thing, wouldn't `LinuxRemoteTI` will have `is_windows` set to `True` when cross-compiling from Windows, and so need the analogical treatment as you do for Windows here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98026/new/

https://reviews.llvm.org/D98026



More information about the libcxx-commits mailing list