[libcxx-commits] [PATCH] D98044: [SystemZ][z/OS] Missing locale functions libc++

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 06:31:43 PST 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I am fine with this change in the sense of how it integrates with the rest of libc++. I did not review the implementation itself - I trust you folks that it works, otherwise it'll break on your own platform :-).

I strongly recommend addressing my small comment about the formatting in `uselocale`.

Comment at: libcxx/src/support/ibm/xlocale_zos.cpp:123-126
+    current_loc->lc_collate = current_loc->lc_ctype =
+    current_loc->lc_monetary = current_loc->lc_numeric =
+    current_loc->lc_time = current_loc->lc_messages =
+    current_loc_name;
This is a really really weird way to save a few lines of code. I would never do that, it looks too much like an unintended mistake.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list