[libcxx-commits] [PATCH] D98036: [libcxx] Apply pragma for silencing warning when building with clang-cl too

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D98036#2606601 <https://reviews.llvm.org/D98036#2606601>, @mstorsjo wrote:

> In D98036#2606546 <https://reviews.llvm.org/D98036#2606546>, @ldionne wrote:
>
>> I assume this warning is necessary because some functions are defined but not used in different configurations? Like a function that would be always defined but only used when building for Windows or the opposite?
>
> No, this is a header under src/filesystem, included by two cpp files in src/filesystem, that contains an anonymous namespace with helper functions (to avoid creating externally visible symbols) used by both src files - but not all of the functions are used by both src files. (And there's one function with multiple overloads, where one overload currently doesn't seem to be used at all, see `const path::value_type* unwrap(path::string_type const& s) { return s.c_str(); }` on line 111.)

Got it, thanks. We could consider removing that overload if it's unused (feel free to do that as a NFC change if you want).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98036/new/

https://reviews.llvm.org/D98036