[libcxx-commits] [PATCH] D97538: [libcxx] [test] Ifdef out tests that rely on perms::none on directories for triggering errors

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 01:43:27 PST 2021


mstorsjo added a comment.

@curdeius Any ideas on this one? There's lots of tests that test the error cases when unable to read a directory, by giving those directories `perms::none`, which doesn't stop them from being read on windows. (On windows, the perms we have available essentially is only a binary readonly-flag.) And if I understand things right, these tests also fail if running the tests as root or in sudo, as one apparently ends up able to read the directories regardless, in those cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97538/new/

https://reviews.llvm.org/D97538



More information about the libcxx-commits mailing list