[libcxx-commits] [PATCH] D89943: [libcxx] [test] Fix path.decompose for windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 01:31:21 PST 2021

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.

Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.decompose/path.decompose.pass.cpp:95
     , {"//net/foo", {"/", "net", "foo"}, "/", "", "/", "net/foo", "/net", "foo"}
     , {"///foo///", {"/", "foo", ""}, "/", "", "/", "foo///", "///foo", ""}
Quuxplusone wrote:
> Conspicuously missing here: `"//net/"`. Any thoughts on adding it as part of this patch?
> (LGTM modulo I don't actually get what's going on here. Is it that this test is currently red on Windows and you're just adding the correct test code to make it green on Windows? You don't have to remove any XFAILs or anything as part of this patch?)
Good point, I updated the patch including that.

The testing situation in Windows is that I think there used to be a buildbot some years ago, but it is no longer there, and things had regressed a fair bit meanwhile (with at least two different issues that caused 99% of tests to fail). That's all done and fixed now, so right now only around 87 or so tests fail (out of 6.5k). If someone would be willing to set up a buildbot for it (my contributions here are as a voluntary opensource developer only), we could add XFAIL on the remaining bit and track it from there.

Then secondly, these tests for std::filesystem never worked on windows at all. Nowadays the implementation of std::filesystem is working fine on windows (modulo an issue with `__int128` in MSVC configurations, see D91139 for discussion around that), but the tests aren't quite there yet.

So for both of those reasons, there's no XFAIL here to remove, but yeah, this patch brings the number of failing tests down from 45 (out of 136) to 44. I've got a series of around 18 patches that fixes all of them (out of which a couple are up for review so far), I'm putting up more of them for review as the current ones get reviewed.



More information about the libcxx-commits mailing list