[libcxx-commits] [PATCH] D98015: [libcxx] Simplify rounding of durations in win32 __libcpp_thread_sleep_for
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 5 01:04:29 PST 2021
curdeius added inline comments.
Comment at: libcxx/src/support/win32/thread_win32.cpp:250
+ // round-up to the nearest millisecond
+ chrono::milliseconds __ms = std::chrono::ceil<chrono::milliseconds>(__ns);
// FIXME(compnerd) this should be an alertable sleep (WFSO or SleepEx)
Just a remark, not specific to this patch.
It seems that in `src/` we sometimes use `_VSTD::` and sometimes `std::`, which is pretty much inconsistent.
IMO, we should use `_VSTD::` as much as possible.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits