[libcxx-commits] [PATCH] D97904: [libcxx] updates the feature-test macro generator

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 4 20:00:33 PST 2021

Quuxplusone added a comment.

> So are we addressing issues pre-merge or post-merge? A bit confused on this one, sorry.

For me personally the priority is to get the generated content back in sync with the generator script one way or another. I am //almost// at the point of just running the generator script myself and pushing that diff without review, but I feel like that would be antisocial. ;P  But be aware that anyone who pushes any other change to libcxx (e.g. implementing some other feature macro) //will// probably re-run the script and push the diff without noticing that they're doing so. So it's gonna get back in sync somehow, with or without this PR.

It sounds like @ldionne wants to get to the bottom of the "depends/internal_depends" stuff badly enough to mark this "request changes," plus it's @ldionne, so obviously I'll defer to him.
"Request changes", to me, strongly implies "please address this issue pre-merge." (If Louis didn't mean that, he should say so.)

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list