[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/include/concepts:228
+  { !std::forward<_Tp>(__t) } -> __boolean_testable_impl;
+};
+
----------------
Mordante wrote:
> I'm somewhat surprised the concept is define like this in the Standard, but http://eel.is/c++draft/concept.booleantestable#2 has additional constrains.
> Did I miss the tests for this concept? I'd like some tests, https://en.cppreference.com/w/cpp/concepts/boolean-testable has some examples of valid types: `bool`, `std::true_type`, `std::bitset<N>::reference`, and `int*`.
It's an implementation detail, so I'm not motivated to directly test it. All the `predicate`-based concepts are tested for `bool`, `Bool`, and `int`, but I've expand to include `std::true_type` and `int*`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477