[libcxx-commits] [PATCH] D97913: [runtimes] Use add_lit_testsuite to register lit testsuites

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

>From the CI job, it looks like we are still picking up the standard:

  llvm-lit: /home/libcxx-builder/.buildkite-agent/builds/332e75e1566a-1/llvm-project/libcxx-ci/libcxx/utils/libcxx/test/newconfig.py:25: note: Applied 'add Lit feature c++14' as a result of parameter 'std=c++14'

I don't fully remember what's the issue I was running into, but I just did some archeology and I don't think it can be an issue anymore. Basically, since the CMake caches we use to run the buildbots look like

  set(LIBCXX_TEST_PARAMS "std=c++14" CACHE STRING "")
  set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "")

we're not reusing `LLVM_LIT_ARGS`, and I don't think the issue I was explaining in the commit message can happen anymore. So let's give this a shot. Sorry for the back and forth, this happened a while ago.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97913/new/

https://reviews.llvm.org/D97913